Let Platform Settings follow the deployment unless you change them #84

Merged
Patrick merged 1 commit from patrick/settings-follow-deployment into main 2026-11-19 20:33:45 -05:00 AGit
Owner

Platform Settings stored every field on each save, so one save froze the deployment's values of that moment. On Dallas, the Ollama URL and tracing endpoint kept their docker-compose addresses after the chart started setting in-cluster ones: the status page warned about Ollama and Tempo, and no traces reached Tempo.

What changes

  • A save stores only fields you changed. A value equal to the deployment's own (.env, or the chart's ConfigMap) isn't stored. Clearing a field, or setting it back to the deployment's value, removes the saved value so the setting follows the deployment again.
  • "Reset to default" next to any field with a saved value. It removes the value, applies the deployment's value and restarts what that setting needs, like a save does. The confirmation shows the value it will use (hidden for secrets).
  • Migration removes values saved by accident: rows equal to the deployment's value, and url settings still holding their compose placeholder while the deployment sets another address. Values someone chose are kept. Settings stay editable live; nothing new is locked.

Dallas preview (read-only, run in the pod): 46 saved values equal the deployment's own and would be removed, with no change in behaviour (the whole form frozen by one save). Kept: mail.default = sendgrid, from address/name, and API keys only set in the UI. Side benefit: chart-provided secrets (LiveKit, AMI, Reverb) are no longer pinned in the database, so a future rotation in the chart takes effect.

Checked: 7 new tests in PlatformSettingsPageTest; 5 of them fail against the old save code. Full suite: 513 passed, 8 skipped. Pint clean.

🤖 Generated with Claude Code

Platform Settings stored **every field** on each save, so one save froze the deployment's values of that moment. On Dallas, the Ollama URL and tracing endpoint kept their docker-compose addresses after the chart started setting in-cluster ones: the status page warned about Ollama and Tempo, and no traces reached Tempo. **What changes** - **A save stores only fields you changed.** A value equal to the deployment's own (.env, or the chart's ConfigMap) isn't stored. Clearing a field, or setting it back to the deployment's value, removes the saved value so the setting follows the deployment again. - **"Reset to default"** next to any field with a saved value. It removes the value, applies the deployment's value and restarts what that setting needs, like a save does. The confirmation shows the value it will use (hidden for secrets). - **Migration** removes values saved by accident: rows equal to the deployment's value, and url settings still holding their compose placeholder while the deployment sets another address. Values someone chose are kept. Settings stay editable live; nothing new is locked. **Dallas preview (read-only, run in the pod):** 46 saved values equal the deployment's own and would be removed, with no change in behaviour (the whole form frozen by one save). Kept: mail.default = sendgrid, from address/name, and API keys only set in the UI. Side benefit: chart-provided secrets (LiveKit, AMI, Reverb) are no longer pinned in the database, so a future rotation in the chart takes effect. **Checked:** 7 new tests in PlatformSettingsPageTest; 5 of them fail against the old save code. Full suite: 513 passed, 8 skipped. Pint clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Let Platform Settings follow the deployment unless you change them
All checks were successful
Application Tests / publish-helm (pull_request) Has been skipped
Application Tests / frontend (pull_request) Successful in 33s
Application Tests / security-audit (pull_request) Successful in 2m34s
Application Tests / php (pull_request) Successful in 3m32s
Application Tests / tag (pull_request) Has been skipped
Application Tests / publish-images (., Dockerfile, laravel) (pull_request) Has been skipped
Application Tests / publish-images (agent-worker, Dockerfile, agent-worker) (pull_request) Has been skipped
Application Tests / publish-images (docker/asterisk, Dockerfile, asterisk) (pull_request) Has been skipped
Application Tests / publish-images (docker/asterisk-config-sync, Dockerfile, asterisk-config-sync) (pull_request) Has been skipped
Application Tests / publish-images (docker/haraka, Dockerfile, haraka) (pull_request) Has been skipped
Application Tests / publish-images (docker/whisper-local, Dockerfile, whisper-local) (pull_request) Has been skipped
Application Tests / scan-images (agent-worker) (pull_request) Has been skipped
Application Tests / scan-images (asterisk) (pull_request) Has been skipped
Application Tests / scan-images (asterisk-config-sync) (pull_request) Has been skipped
Application Tests / scan-images (haraka) (pull_request) Has been skipped
Application Tests / scan-images (laravel) (pull_request) Has been skipped
Application Tests / scan-images (whisper-local) (pull_request) Has been skipped
Application Tests / publish-archives (pull_request) Has been skipped
9cd5cf4e64
A save stored every field on the page, so one save froze the
deployment's values of that moment. On Dallas the Ollama URL and
tracing endpoint kept their docker-compose addresses after the chart
started setting in-cluster ones, so the status page warned and traces
never reached Tempo.

- A save stores only a value that differs from the deployment's own
  (.env / chart ConfigMap). Clearing a field or setting it back to the
  deployment's value removes the saved one.
- Each field with a saved value gets a 'Reset to default' hint action
  that removes it, applies the deployment's value and restarts what
  the setting needs, like a save.
- The deployment's value is recorded at boot before overrides apply
  (DeploymentDefaults), since config() alone loses it.
- A migration removes rows that equal the deployment's value, and url
  settings still holding their compose placeholder when the deployment
  sets another address. Values someone chose are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
calltheory/orbital!84
No description provided.